-
Notifications
You must be signed in to change notification settings - Fork 52
[Blade] Whole lotta UI #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DGoel1602
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy frontend
packages/api/src/routers/misc.ts
Outdated
|
|
||
| const formattedDate = formatDate(input.dateNeeded); | ||
|
|
||
| const htmlContent = `<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to consts maybe (a functionw hich takes in all the variables that it needs to make it)
DGoel1602
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Why
I got a handful of requests from execs, and noticed some UI inconsistencies that needed fixing. All of this is anticipation for KH recruiting season.
What
Test Plan