update(docs): Missing test execution times in Minitest#231
Merged
Conversation
3v0k4
approved these changes
Mar 6, 2025
Contributor
3v0k4
left a comment
There was a problem hiding this comment.
There are a few sections in this page that make noise:
- "NameError: uninitialized constant MyModule::MyModelName" does not seem Knapsack Pro related
- "ActiveRecord::SubclassNotFound" same
- "Rake tasks under tests are run more than once in Queue Mode" prolly not a problem anymore since 7.0?
Any chance we can remove any of those?
Member
Author
I think this one we could remove.
This one we can keep it. Someone reported this issue and it was also in Regular Mode.
I've tested it, and tests fail with Knapsack Pro (top left pane) if you load the rake task yourself in a spec (bottom right pane). But they pass if you run it directly via RSpec (bottom left pane). I'd like to keep this so we have a reference with an example to show users if someone struggles with the rake tasks.
The 1st one could be removed. I'll do it. |
Co-authored-by: Riccardo <riccardo.odone@gmail.com>
…constant MyModule::MyModelName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.