fix(FullScreenRenderWindow): add warning that this class is for examples only#3369
Open
daker wants to merge 1 commit intoKitware:masterfrom
Open
fix(FullScreenRenderWindow): add warning that this class is for examples only#3369daker wants to merge 1 commit intoKitware:masterfrom
daker wants to merge 1 commit intoKitware:masterfrom
Conversation
finetjul
reviewed
Dec 2, 2025
| 'controlContainer', | ||
| ]); | ||
|
|
||
| vtkWarningMacro( |
Member
There was a problem hiding this comment.
We can't really prevent (i.e. bother with a warning message) anyone from using FullScreenRenderWindow.
We could think of conditionally testing if hostname is not "localhost" to decide to print a message.
An alternative is to simply document the class that resizing is not possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
fixes #3229
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting