Draft: Refactor Looking Glass WebXR support#2959
Draft
tbirdso wants to merge 3 commits intoKitware:masterfrom
Draft
Draft: Refactor Looking Glass WebXR support#2959tbirdso wants to merge 3 commits intoKitware:masterfrom
tbirdso wants to merge 3 commits intoKitware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Working branch to separate general WebXR behavior from behavior specific to the Looking Glass WebXR polyfill for holographic rendering.
I do not expect to have bandwidth to revisit this work. Others are welcome to pick up this draft PR and carry it to completion. Or, project maintainers are welcome to close the draft PR if it is determined that these changes will not be pursued.
Results
Changes
vtkWebXRLookingGlassRenderWindowHelpersubclass for behavior specific to the Looking Glass WebXR polyfillvtkWebXRRenderWindowHelperto exposegetRendererViewportmethod for subclass override. For instance, the Looking Glass display can override the method to indicate what quilt patch should be drawn for a given view.PR and Code Checklist
npm run reformatto have correctly formatted codeTesting
fyi @floryst