WIP:Picking for volume rendering#2885
Open
danielmazurkin wants to merge 2 commits intoKitware:masterfrom
Open
Conversation
danielmazurkin
changed the title
finetjul
reviewed
Aug 7, 2023
| // Opacity MTimes | ||
| if (model.componentData[index].scalarOpacity) { | ||
| // time that Scalar opacity transfer function was last modified | ||
| // time that Scalar opаacity transfer function was last modified |
finetjul
reviewed
Aug 7, 2023
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
Please follow the VTK.js coding style (apply linting rules in your IDE?).
I'm also curious if you considered the VTK C++ implementation of picking volume rendering...
Contributor
|
Hi, thanks for the contribution! It looks like you were editing the packaged version of vtk.js. You'll need to apply your changes to the vtk.js repository code before we can take a better look. Since you did mark this as WIP, let us know when this is ready for review. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Addresses #2190
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting