Open
Conversation
Collaborator
Author
|
@bluemellophone The new tests are failing to process example3.wav and example4.wav but not 1 or 2. Any idea why that might be? I just tried a fresh environment install on my computer and it passes the tests. edit: Tests also pass within the docker container. |
Collaborator
|
Following up, see here |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
========================================
+ Coverage 57.4% 70.6% +13.2%
========================================
Files 7 9 +2
Lines 1317 1354 +37
========================================
+ Hits 756 956 +200
+ Misses 561 398 -163
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
@bluemellophone Should be ready for your review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding tests of batbot preprocess CLI with and without fast mode processing. Includes regression test on the example wav files.