Modify ingest script to check a local directory#443
Merged
Conversation
naglepuff
force-pushed
the
local-vetting-ingest
branch
2 times, most recently
from
87be481 to
14e2115
Compare
BryonLewis
requested changes
Apr 2, 2026
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Minor comment about file being open to check for existence.
| assert data_dir | ||
| filename = str(data_dir / s3_key) | ||
| try: | ||
| f = open(filename) |
Collaborator
There was a problem hiding this comment.
should this just be a Path(dat_dir /s3_key) exists?
Otherwise I think you're opening a file in text mode, leaving it open and then later on opening it in binary mode when you create the recording.
Collaborator
Author
There was a problem hiding this comment.
Good catch, fixed now
naglepuff
force-pushed
the
local-vetting-ingest
branch
from
14e2115 to
f4f57f4
Compare
BryonLewis
approved these changes
Apr 2, 2026
Collaborator
|
I'm also noticing linting is failing if you want to resolve that first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.