Open
Conversation
Collaborator
Author
|
@jourdain Please review |
Points are created from variables in the connectivity file: double grid_corner_lat(grid_size, grid_corners) ; double grid_corner_lon(grid_size, grid_corners) ;
Collaborator
|
Can you follow https://www.conventionalcommits.org/en/v1.0.0/ for your commit message. That way, the changelog and updated version on PyPI/conda will reflect your work. If you don't mind not keeping your separate commits, I can squash them using a correct syntax from the web UI. Just let me know. |
Collaborator
|
Otherwise your changes seems reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.