Skip to content

Make 'separate_bodies' default to false, both in Rust and in JSON#1089

Merged
mlfarrell merged 1 commit intomike/csg-separate-bodiesfrom
achalmers/pr-into-pr
Feb 13, 2026
Merged

Make 'separate_bodies' default to false, both in Rust and in JSON#1089
mlfarrell merged 1 commit intomike/csg-separate-bodiesfrom
achalmers/pr-into-pr

Conversation

@adamchalmers
Copy link
Collaborator

If you put #[serde(default)] it'll use the default value for that field's type (e.g. ints default to 0, strings default to "", and you can define whatever defaults you want for your type.

If you put #[builder(default)] then the builder API will use the default too, and users can override that default of course.

@adamchalmers adamchalmers changed the base branch from main to mike/csg-separate-bodies February 13, 2026 22:30
@mlfarrell mlfarrell merged commit e61cc53 into mike/csg-separate-bodies Feb 13, 2026
10 checks passed
@mlfarrell mlfarrell deleted the achalmers/pr-into-pr branch February 13, 2026 22:31
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.19%. Comparing base (754c322) to head (f35fa4a).
⚠️ Report is 1 commits behind head on mike/csg-separate-bodies.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           mike/csg-separate-bodies    #1089   +/-   ##
=========================================================
  Coverage                     26.19%   26.19%           
=========================================================
  Files                            35       35           
  Lines                          1756     1756           
=========================================================
  Hits                            460      460           
  Misses                         1296     1296           
Flag Coverage Δ
unittests 26.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants