Skip to content

Conversation

@zoo-github-actions-auth
Copy link
Contributor

Updating the spec from that in the api repo

Comment on lines +9914 to +9920
"content": {
"multipart/form-data": {
"schema": {
"type": "string",
"format": "binary"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multipart/form-data schema is incorrectly defined for multiple file uploads. The description states "each file part becomes a source object" (line 9900), and the response includes uploaded_files (plural), but the schema is defined as a single string with binary format. This will not properly handle multiple file parts in a multipart request.

Fix: Change the schema to properly accept multiple files:

"schema": {
  "type": "object",
  "additionalProperties": {
    "type": "string",
    "format": "binary"
  }
}

Or use an array if files share the same field name:

"schema": {
  "type": "array",
  "items": {
    "type": "string",
    "format": "binary"
  }
}
Suggested change
"content": {
"multipart/form-data": {
"schema": {
"type": "string",
"format": "binary"
}
}
"content": {
"multipart/form-data": {
"schema": {
"type": "object",
"additionalProperties": {
"type": "string",
"format": "binary"
}
}
}

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@jessfraz jessfraz enabled auto-merge (squash) February 12, 2026 00:45
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.10%. Comparing base (a070205) to head (cfef768).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files          41       41           
  Lines        6778     6778           
=======================================
  Hits         4684     4684           
  Misses       2094     2094           
Flag Coverage Δ
unittests 69.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jessfraz jessfraz merged commit 9f293f4 into main Feb 12, 2026
17 checks passed
@jessfraz jessfraz deleted the update-spec branch February 12, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant