Skip to content

Remove Custom Fields and Sequences on Disconnect #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n7studios merged 1 commit into from
Dec 2, 2025
Merged

Remove Custom Fields and Sequences on Disconnect #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions admin/section/class-convertkit-admin-section-general.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,16 +198,20 @@ private function maybe_disconnect() {

// Delete cached resources.
$creator_network = new ConvertKit_Resource_Creator_Network_Recommendations();
$custom_fields = new ConvertKit_Resource_Custom_Fields();
$forms = new ConvertKit_Resource_Forms();
$landing_pages = new ConvertKit_Resource_Landing_Pages();
$posts = new ConvertKit_Resource_Posts();
$products = new ConvertKit_Resource_Products();
$sequences = new ConvertKit_Resource_Sequences();
$tags = new ConvertKit_Resource_Tags();
$creator_network->delete();
$custom_fields->delete();
$forms->delete();
$landing_pages->delete();
$posts->delete();
$products->delete();
$sequences->delete();
$tags->delete();

// Redirect to General screen, which will now show the ConvertKit_Settings_OAuth screen, because
Expand Down
10 changes: 10 additions & 0 deletions tests/EndToEnd/general/plugin-screens/PluginSettingsGeneralCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,16 @@ public function testValidCredentials(EndToEndTester $I)
// Disconnect the Plugin connection to Kit.
$I->click('Disconnect');

// Check cached resources are removed from the database on disconnection.
$I->dontSeeOptionInDatabase('convertkit_creator_network_recommendations');
$I->dontSeeOptionInDatabase('convertkit_custom_fields');
$I->dontSeeOptionInDatabase('convertkit_forms');
$I->dontSeeOptionInDatabase('convertkit_landing_pages');
$I->dontSeeOptionInDatabase('convertkit_posts');
$I->dontSeeOptionInDatabase('convertkit_products');
$I->dontSeeOptionInDatabase('convertkit_sequences');
$I->dontSeeOptionInDatabase('convertkit_tags');

// Confirm the Connect button displays.
$I->see('Connect');
$I->dontSee('Disconnect');
Expand Down