Tests: Improve Reliability #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s have the same email address
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
corydhmiller and
noelherrick
and removed request for
a team
…ext-link-compat-6-9
noelherrick
approved these changes
Nov 18, 2025
| { | ||
| return 'wordpress-' . date( 'Y-m-d-H-i-s' ) . '-php-' . PHP_VERSION_ID . '@' . $domain; | ||
| $date = \DateTime::createFromFormat('U.u', number_format(microtime(true), 6, '.', '')); | ||
| return 'wordpress-' . $date->format('Y-m-d-H-i-s-u') . '-php-' . PHP_VERSION_ID . '@' . $domain; |
Contributor
There was a problem hiding this comment.
If we keep getting collisions, we might want to think about APIs specifically designed for randomness, something like base64_encode(random_bytes($length))
…at-6-9 Member Content: Courses: Improve SQL query for 6.9 compat.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves reliability of end to end tests, by:
--disable-software-rasterizerwaitForElementVisibleby checking for a unique element on page load vs. an existing element that always existshrefattribute)microtime()when generating a unique email addressTesting
Existing tests pass.
Checklist