-
Notifications
You must be signed in to change notification settings - Fork 0
Composer: Add Commands #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
noelherrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got me wondering if we should alias these with generalized names, like you did with "test-integration":
- run-coding-standards(-on-tests)
- run-beautifier(-on-tests)
- run-static-analysis
Thoughts?
Command names match the underlying command where possible, to save developers guessing (e.g. For a full list of commands used in the Plugins, see the table in this PR. We don't have e.g. If you think there are improvements that can be made, let me know and I'm open to updating each Plugin to reflect this. |
|
I suggested aliases because as someone who's not using these commands daily, I was vaguely aware that we had a linter/coding standards tool, didn't know we had a beautifier, and thought the PHPStan was the main automatic tool we were using. My thought was to add aliases as a way to document the different code tools. |
Alias commands added. Original commands remain as faster to type and use for my development workflow. |
Summary
Registers a number of commands in the
scriptssection of Composer, which serve as shorthand commands for testing and other common tasks performed in development, to save repetitively typing longer commands with commonly used flags / arguments.phpcsphpcs-testsphpstantest-integrationAdds alias commands:
coding-standardsfix-coding-standardscoding-standards-on-testsfix-coding-standards-on-testsstatic-analysisCommands can be run using e.g.
composer test-integrationorcomposer static-analysisTesting
Existing tests pass
Checklist