Skip to content

Conversation

@n7studios
Copy link
Contributor

Summary

PHPStan's static analysis now only works on PHP 8.0 and higher, due to WordPress' stubs including #[\SensitiveParameter]:

Screenshot 2025-10-29 at 16 15 39

This results in syntax errors in PHP 7.4 and lower:

Screenshot 2025-10-29 at 16 09 46

This PR resolves by running static analysis on PHP 8.0 and higher.
Coding standards are run on PHP 7.2 and higher, to ensure backward compatibility should some users be on extremely old versions of PHP.
End to end tests run have been running on PHP 8.1 since May 2025

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Nov 3, 2025
@n7studios n7studios added the enhancement New feature or request label Nov 3, 2025
@n7studios n7studios requested review from a team, corydhmiller and noelherrick and removed request for a team November 3, 2025 14:38
@n7studios n7studios marked this pull request as ready for review November 3, 2025 14:38
@n7studios n7studios merged commit c66d0c3 into main Nov 4, 2025
20 of 23 checks passed
@n7studios n7studios deleted the test-phpstan-php-8 branch December 5, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants