Skip to content

patch: add custom logging for apis #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpit-sangotra wants to merge 1 commit into
base: release-x.45.x
Choose a base branch
from
Open

patch: add custom logging for apis #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/metabase/api/permissions.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"/api/permissions endpoints."
(:require [clojure.spec.alpha :as s]
[compojure.core :refer [DELETE GET POST PUT]]
[clojure.tools.logging :as log]
[honeysql.helpers :as hh]
[metabase.api.common :as api]
[metabase.api.common.validation :as validation]
Expand Down Expand Up @@ -179,6 +180,7 @@
(api/check
(db/exists? User :id user_id :is_superuser false)
[400 (tru "Admin cant be a group manager.")]))
(log/debug "PERMISSION_MEMBERSHIP_CREATED : AUTHOR: %s : USER_AFFECTED : %s : GROUP : %s" (api/*current-user-id*) (user_id) (group_id))
(db/insert! PermissionsGroupMembership
:group_id group_id
:user_id user_id
Expand Down Expand Up @@ -211,6 +213,7 @@
(let [membership (db/select-one PermissionsGroupMembership :id id)]
(api/check-404 membership)
(validation/check-manager-of-group (:group_id membership))
(log/debug "PERMISSION_MEMBERSHIP_REMOVED : AUTHOR: %s : USER_AFFECTED : %s : GROUP : %s" (api/*current-user-id*) (:user_id membership) (:group_id membership))
(db/delete! PermissionsGroupMembership :id id)
api/generic-204-no-content))

Expand Down