fix(cli): stop loading .opencode config directories#8920
Closed
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Closed
fix(cli): stop loading .opencode config directories#8920kilo-code-bot[bot] wants to merge 2 commits intomainfrom
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Conversation
| if (acc.result.plugin?.length) { | ||
| for (const dir of unique(directories)) { | ||
| if (!dir.endsWith(".opencode") && dir !== Flag.KILO_CONFIG_DIR) continue | ||
| if (!dir.endsWith(".kilo") && !dir.endsWith(".kilocode") && dir !== Flag.KILO_CONFIG_DIR) continue // kilocode_change |
Contributor
Author
There was a problem hiding this comment.
WARNING: Global TUI plugin dependencies are skipped from the default config directory
ConfigPaths.directories() still includes Global.Path.config, but this new filter only allows .kilo, .kilocode, and KILO_CONFIG_DIR. When a user configures TUI plugins in the normal global config location, waitForDependencies() no longer calls installDeps(Global.Path.config), so those plugins can fail to load because their dependencies were never installed there.
Contributor
Author
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found outside the diff. Files Reviewed (24 files)
Reviewed by gpt-5.4-20260305 · 3,940,108 tokens |
099e7a4 to
8001129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary