Hide Early Bird card on KiloClaw provisioning page#772
Closed
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Closed
Hide Early Bird card on KiloClaw provisioning page#772kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
| </div> | ||
| </PageLayout> | ||
| ); | ||
| return null; |
Contributor
Author
There was a problem hiding this comment.
WARNING: Returning null means users who bookmarked or were linked to /claw/earlybird will see a blank page. Consider redirecting to /claw instead:
Suggested change
| return null; | |
| redirect('/claw'); |
(with import { redirect } from 'next/navigation'; at the top)
Contributor
Author
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (2 files)
|
Contributor
|
I believe this is made moot by #773 fixing the root problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EarlybirdBannercomponent from the KiloClaw dashboard (ClawDashboard.tsx), so the Early Bird promo card no longer appears on the provisioning page./claw/earlybird) with a no-op render (return null) so navigating to that route no longer shows the offer.Built for Florian by Kilo for Slack