Fail explicitly when multiple owners found for Slack/Discord bot messages#758
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
Fail explicitly when multiple owners found for Slack/Discord bot messages#758kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
…ages Previously, if multiple integrations existed for the same Slack workspace or Discord server (e.g. installed on both a personal account and an org), the bot would non-deterministically pick one, causing unpredictable failures. Now the bot detects duplicate integrations and returns a clear error message to the user asking them to remove the duplicate, instead of proceeding with an arbitrary installation.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| return db | ||
| .select() | ||
| .from(platform_integrations) | ||
| .where( |
Contributor
Author
There was a problem hiding this comment.
[WARNING]: This query does not filter by integration_status. A suspended or pending integration would count toward the duplicate check, potentially blocking a valid active integration from being used.
Consider adding eq(platform_integrations.integration_status, INTEGRATION_STATUS.ACTIVE) to the and(...) clause. The same applies to the Slack counterpart getAllInstallationsByTeamId.
| return db | ||
| .select() | ||
| .from(platform_integrations) | ||
| .where( |
Contributor
Author
There was a problem hiding this comment.
[WARNING]: Same as the Discord counterpart — this query does not filter by integration_status. A suspended integration would be counted as a duplicate, causing the bot to reject messages even if only one integration is actually active.
Contributor
Author
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (4 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAllInstallationsByTeamIdandgetAllInstallationsByGuildIdquery functions to support the duplicate detection.Changes
src/lib/integrations/slack-service.tsgetAllInstallationsByTeamId()src/lib/integrations/discord-service.tsgetAllInstallationsByGuildId()src/lib/slack-bot.tsprocessKiloBotMessage()src/lib/discord-bot.tsprocessDiscordBotMessage()Built for Remon Oldenbeuving by Kilo for Slack