Skip to content

fix(code-reviews): retry mkdir failures#3298

Merged
alex-alecu merged 5 commits into
mainfrom
fix/code-review-workspace-mkdir-retry
May 19, 2026
Merged

fix(code-reviews): retry mkdir failures#3298
alex-alecu merged 5 commits into
mainfrom
fix/code-review-workspace-mkdir-retry

Conversation

@alex-alecu
Copy link
Copy Markdown
Contributor

@alex-alecu alex-alecu commented May 18, 2026

Summary

  • Treat Cloud Agent workspace directory setup failures as retryable infrastructure failures and destroy the bad sandbox before callers retry.
  • Preserve sandbox startup failures as the cause on WrapperNotReadyError so existing sandbox-500 recovery can detect ProcessExitedBeforeReadyError-style failures.
  • Keep code-review retries marker-driven and one-shot; plain prose errors still do not trigger retry behavior.

Verification

No manual verification performed; this change is backend error propagation and retry classification only.

Visual Changes

N/A

Reviewer Notes

  • Sandbox recovery is intentionally structural: httpStatus: 500 causes are classified, while generic HTTP 500 message text alone is not.
  • Wrapper startup cause preservation lets the existing prepare-session/code-review retry marker path handle sandbox startup 500s without a new retry policy.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 18, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The final commit (0c72ce3) removes the dead withSandboxInternalServerErrorRecovery export and migrates its single test to use withPreparationInfrastructureRecovery, resolving the previously flagged dead-code issue. No new issues introduced across all reviewed commits.

Files Reviewed (14 files)
  • services/cloud-agent-next/src/execution/orchestrator.ts
  • services/cloud-agent-next/src/kilo/wrapper-client.tsErrorOptions propagation
  • services/cloud-agent-next/src/kilo/wrapper-client.test.ts — cause-preservation test
  • services/cloud-agent-next/src/persistence/async-preparation.ts
  • services/cloud-agent-next/src/router/handlers/session-prepare.ts — structured failure-category logging
  • services/cloud-agent-next/src/sandbox-recovery.ts — dead withSandboxInternalServerErrorRecovery removed ✓
  • services/cloud-agent-next/src/sandbox-recovery.test.ts — test migrated to withPreparationInfrastructureRecovery
  • services/cloud-agent-next/src/session-prepare.test.ts
  • services/cloud-agent-next/src/workspace-errors.ts
  • services/cloud-agent-next/src/workspace.test.ts
  • services/cloud-agent-next/src/workspace.ts
  • services/code-review-infra/test/integration/code-review-orchestrator.test.ts

Reviewed by claude-4.6-sonnet-20260217 · 210,528 tokens

Review guidance: REVIEW.md from base branch main

…pace-mkdir-retry

# Conflicts:
#	services/cloud-agent-next/src/router/handlers/session-prepare.ts
#	services/code-review-infra/test/integration/code-review-orchestrator.test.ts
Comment thread services/cloud-agent-next/src/execution/orchestrator.ts
@alex-alecu alex-alecu merged commit 3af2dcc into main May 19, 2026
13 checks passed
@alex-alecu alex-alecu deleted the fix/code-review-workspace-mkdir-retry branch May 19, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants