Add offset test to webgl-compressed-texture-astc #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lexaknyazev
reviewed
Dec 11, 2025
|
|
||
| // Upload with offsets | ||
| tex = setupEmptyTexture(gl.TEXTURE_2D, false); | ||
| wtu.glErrorShouldBe(gl, gl.NO_ERROR, "allocating empty compressed texture array via compressedTexImage3D"); |
| // ASTC block size is always 16 bytes (128 bits) | ||
| const offset = (width / blockSize.width + height / blockSize.height - 1) * 16; | ||
|
|
||
| gl.compressedTexSubImage2D(target, 0, x, y, blitWidth, blitHeight, format, data, offset); |
Member
There was a problem hiding this comment.
For completeness, please also test the length override parameter like
compressedTexSubImage2D(target, 0, x, y, blitWidth, blitHeight, format, data,
0, data.length - offset)| checkResult(target, [gl.NO_ERROR, gl.INVALID_ENUM, gl.INVALID_ENUM ], "2D", true); | ||
|
|
||
| if (useES3) { | ||
| gl.compressedTexSubImage3D(target, 0, x, y, 0, blitWidth, blitHeight, 1, format, data, offset); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
compressedTexSubImage3Don a layered texture with a non-null y offset is currently raising anINVALID_VALUEon Meta Quest 2.This PR adds a test that ensures using an offset works as expected.
EDIT: Looks like the behavior is broken on a lot of Qualcomm chips. Test fails on Browserstack for Samsung Galaxy Z Fold / S25, as well as OnePlus phones