Test uploading individual LOD levels to 3D textures from images #3699
+126
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
Notes:
|
Jimbly
commented
Oct 19, 2024
| if (useMinMax) { | ||
| // Note: this seems like it should work, but fails on uint textures, | ||
| // bug in test / test author, or bug in implementations? | ||
| gl.texParameterf(bindingTarget, gl.TEXTURE_MIN_LOD, lod); |
Author
There was a problem hiding this comment.
Using TEXTURE_MIN/MAX_LOD here works in all tests except for the unsigned integer formats (where it appears to sample from the wrong level). I'm not sure if that means there's something I don't understand, or if I've stumbled upon a bug. I'd be happy to change this code to also test the alternative way to choose which lod levels are sampled from, or to remove this (currently unreachable) branch if desired.
Author
|
Anything required to get this merged or anything I can do to help move the process along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://issues.chromium.org/issues/40910322