Skip to content

Add web3dsurvey data gathering to specs and extensions. #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenrussell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add web3dsurvey data gathering to specs and extensions. #3535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion extensions/extension.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
<p><strong>DO NOT IMPLEMENT!!!</strong></p>
</xsl:if>

<xsl:comment>Help the community by recording statistics on availability of 3D APIs. Trick to prevent XSL processor from creating an illegal self-closing iframe tag.</xsl:comment>
<iframe src="https://web3dsurvey.com/collector-iframe.html" style="width: 1px; height: 1px;" frameborder="0"><xsl:text>&#160;</xsl:text></iframe>
Copy link
Contributor

@greggman greggman May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about

<iframe src="https://web3dsurvey.com/collector-iframe.html" width="1" height="1" style="border: none;">

IIUC, the code as is is asking for a 300x150 iframe to be scaled to 1x1 where as the suggested code is asking for a 1x1 iframe. Also frameborder="0" is deprecated.

Copy link
Contributor

@kainino0x kainino0x May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the width/height attributes do the same thing as the CSS, on iframes. So could just as well be all CSS.

Copy link
Contributor

@greggman greggman May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Thanks!


<h2 class="no-toc">Name</h2>
<p> <xsl:value-of select="name" /> </p>

Expand Down Expand Up @@ -184,7 +187,6 @@
<xsl:apply-templates select="history/revision">
<xsl:sort select="@date" />
</xsl:apply-templates>

</body>
</html>
</xsl:template>
Expand Down
2 changes: 2 additions & 0 deletions extensions/registry.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
<script src="../resources/generateTOC.js" type="text/javascript"></script>
</head>
<body>
<!-- Help the community by recording statistics on availability of 3D APIs -->
<iframe src="https://web3dsurvey.com/collector-iframe.html" style="width: 1px; height: 1px;" frameborder="0"></iframe>
<!--begin-logo-->
<div class="head">
<div class="left">
Expand Down
2 changes: 2 additions & 0 deletions specs/latest/1.0/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
<script src="../../../resources/generateTOC.js" type="application/javascript"></script>
</head>
<body onload="generateTOC(document.getElementById('toc'))">
<!-- Help the community by recording statistics on availability of 3D APIs -->
<iframe src="https://web3dsurvey.com/collector-iframe.html" style="width: 1px; height: 1px;" frameborder="0"></iframe>
<!--begin-logo-->
<div class="head">
<div class="left">
Expand Down
2 changes: 2 additions & 0 deletions specs/latest/2.0/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
<script src="../../../resources/generateTOC.js" type="application/javascript"></script>
</head>
<body onload="generateTOC(document.getElementById('toc'))">
<!-- Help the community by recording statistics on availability of 3D APIs -->
<iframe src="https://web3dsurvey.com/collector-iframe.html" style="width: 1px; height: 1px;" frameborder="0"></iframe>
<!--begin-logo-->
<div class="head">
<div class="left">
Expand Down