Skip to content

Testing PR: Require rgb renderable webgl1. #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenrussell merged 4 commits into from
Dec 23, 2021
Merged

Testing PR: Require rgb renderable webgl1. #3372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e20ad3
Add format-filterable-renderable test.
kdashg Nov 5, 2021
2b34ea4
Make webgl1 non-RGBA8 formats `render: undefined`.
kdashg Nov 18, 2021
6124ff9
Require all RGB and RGBA textures to be renderable in webgl1.
kdashg Nov 18, 2021
4caaead
Merge branch 'require-rgb-renderable-webgl1' of https://github.com/jd…
kenrussell Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdk/tests/conformance/textures/misc/format-filterable-renderable.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@
// GLES 2.0.25 p63
const FORMAT_INFO_WEBGL1 = {
RGBA8 : { filter: true, render: true , unpack: ['RGBA', 'UNSIGNED_BYTE'] },
RGB8 : { filter: true, render: undefined, unpack: ['RGB', 'UNSIGNED_BYTE'] },
RGBA4 : { filter: true, render: undefined, unpack: ['RGBA', 'UNSIGNED_SHORT_4_4_4_4'] },
RGB5_A1: { filter: true, render: undefined, unpack: ['RGBA', 'UNSIGNED_SHORT_5_5_5_1'] },
RGB565 : { filter: true, render: undefined, unpack: ['RGB', 'UNSIGNED_SHORT_5_6_5'] },
RGB8 : { filter: true, render: true , unpack: ['RGB', 'UNSIGNED_BYTE'] },
RGBA4 : { filter: true, render: true , unpack: ['RGBA', 'UNSIGNED_SHORT_4_4_4_4'] },
RGB5_A1: { filter: true, render: true , unpack: ['RGBA', 'UNSIGNED_SHORT_5_5_5_1'] },
RGB565 : { filter: true, render: true , unpack: ['RGB', 'UNSIGNED_SHORT_5_6_5'] },
LA8 : { filter: true, render: false , unpack: ['LUMINANCE_ALPHA', 'UNSIGNED_BYTE'] },
L8 : { filter: true, render: false , unpack: ['LUMINANCE', 'UNSIGNED_BYTE'] },
A8 : { filter: true, render: false , unpack: ['ALPHA', 'UNSIGNED_BYTE'] },
Expand Down
16 changes: 13 additions & 3 deletions specs/latest/1.0/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3892,9 +3892,19 @@ <h3><a name="FBO_ATTACHMENTS">Framebuffer Object Attachments</a></h3>
framebuffer being framebuffer complete:

<ul>
<li> <code>COLOR_ATTACHMENT0</code> = <code>RGBA/UNSIGNED_BYTE</code> texture
<li> <code>COLOR_ATTACHMENT0</code> = <code>RGBA/UNSIGNED_BYTE</code> texture + <code>DEPTH_ATTACHMENT</code> = <code>DEPTH_COMPONENT16</code> renderbuffer
<li> <code>COLOR_ATTACHMENT0</code> = <code>RGBA/UNSIGNED_BYTE</code> texture + <code>DEPTH_STENCIL_ATTACHMENT</code> = <code>DEPTH_STENCIL</code> renderbuffer
<li> renderbuffer or color-renderable texture
<li> renderbuffer or color-renderable texture + <code>DEPTH_ATTACHMENT</code> = <code>DEPTH_COMPONENT16</code> renderbuffer
<li> renderbuffer or color-renderable texture + <code>DEPTH_STENCIL_ATTACHMENT</code> = <code>DEPTH_STENCIL</code> renderbuffer
</ul>

A texture is color-renderable if it has any of the following format-type pairs:

<ul>
<li> <code>RGBA</code>, <code>UNSIGNED_BYTE</code>
<li> <code>RGB</code>, <code>UNSIGNED_BYTE</code>
<li> <code>RGBA</code>, <code>UNSIGNED_SHORT_4_4_4_4</code>
<li> <code>RGBA</code>, <code>UNSIGNED_SHORT_4_4_4_4</code>
<li> <code>RGB</code>, <code>UNSIGNED_SHORT_5_6_5</code>
</ul>

<h3><a name="TEXTURE_UPLOAD_SIZE">Texture Upload Width and Height</a></h3>
Expand Down