Add Duck IVF parsing support to the elementary stream.#18
Open
vasn1k wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Add Duck IVF parsing support to the elementary stream.#18vasn1k wants to merge 1 commit intoKhronosGroup:mainfrom
vasn1k wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
|
|
dabrain34
requested changes
Mar 12, 2025
| #define DKIF_FRAME_CONTAINER_HEADER_SIZE 12 | ||
| #define DKIF_HEADER_MAGIC *((const uint32_t*)"DKIF") | ||
| #define DKIF_FILE_HEADER_SIZE 32 | ||
| #define USE_SIMPLE_MALLOC 1 |
Contributor
There was a problem hiding this comment.
I'm a bit confused about this USE_SIMPLE_MALLOC. Can you add a comment to explain the use of that ?
Contributor
Author
There was a problem hiding this comment.
I'll remove it the define. It's there for debugging purposes.
Contributor
|
We should remove the USE_SIMPLE_MALLOC from this change. @vasn1k, per our offline discussion, please do that before we merge this change. |
Signed-off-by: Vassili Nikolaev (NVIDIA) <vnikolaev@nvidia.com>
Contributor
|
@vasn1k could you make the change needed for this PR ? |
Contributor
|
Can you please remove the ifdef with USE_SIMPLE_MALLOC @vasn1k as it will be removed at the end avoiding the dead code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for .ivf files when loading AV1 compressed video files and using elementary streams.