FindShaderc: enhance the detection#103
Merged
dabrain34 merged 1 commit intoKhronosGroup:mainfrom Oct 15, 2025
Merged
Conversation
Contributor
Author
|
@srinathkr-nv or @zlatinski can you have a look to this MR which will allow to merge #53 |
In order to be used by CTS, the shaderc cmake script should detect properly glslang and spirv-headers from an external source such as CTS.
dabrain34
force-pushed
the
dab_fix_shaderc_cts
branch
from
65fdd94 to
f974f14
Compare
Contributor
|
mostly looks good to me but I guess it maybe need more testing on various platforms... |
zlatinski
approved these changes
Oct 14, 2025
Contributor
zlatinski
left a comment
zlatinski
left a comment
There was a problem hiding this comment.
LGTM: thank you for the enhancements Stephane!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be used by CTS, the shaderc cmake script should detect properly glslang and spirv-headers from an external source such as CTS.