layers: Add checks and tests for VU 9941 - WIP

[stefano-bucciarelli-arm]

This is very specific for datagraphs defined with TOSA in a spirv program.
The unit test does NOT create a negative case; it is a positive test for testing and needs to be modified.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[spencer-lunarg]

this crashes locally because my machine doesn't have this function, you are going to need to warp this with

const std::unordered_map<uint32_t, std::vector<VkQueueFamilyDataGraphPropertiesARM>> PhysicalDevice::GetQueueFamilyDataGraphProps(VkPhysicalDevice phys_dev) {
    std::unordered_map<uint32_t, std::vector<VkQueueFamilyDataGraphPropertiesARM>> all_properties;
    if (has_arm_tensors) {

    }
    return all_properties;
}

... see PhysicalDevice::has_maintenance9 as an example

[stefano-bucciarelli-arm]

copying what we do with has_maintenance9 doesn't work, it gets initialize after we pass through here.
Is there another way to check if an extension is supported at this stage?

[stefano-bucciarelli-arm]

and how can DispatchGetPhysicalDeviceQueueFamilyDataGraphPropertiesARM be undefined? It's in the generated vulkan code, layers/vulkan/generated/dispatch_functions.h.

[spencer-lunarg]

The function is just null, there is no implementation in my driver, so it crashes

What we can do is just cache it, the first time someone calls it in the command buffer it gets the value, the 2nd time, it just reads from it

[stefano-bucciarelli-arm]

I pushed something to check if the function is not null in the dispatch table, does this work?
Is there a simple way to make the mock ICD emulate the issue for testing, i.e. force dispatch_table.GetPhysicalDeviceQueueFamilyDataGraphPropertiesARM == nullptr?

[spencer-lunarg]

@stefano-bucciarelli-arm just remove it from TestICD and try to run any test, it will crash quite quickly

diff --git a/layers/vulkan/generated/test_icd_helper.h b/layers/vulkan/generated/test_icd_helper.h
index 8b34680c1..66fcb94e5 100644
--- a/layers/vulkan/generated/test_icd_helper.h
+++ b/layers/vulkan/generated/test_icd_helper.h
@@ -2140,9 +2140,6 @@ static VKAPI_ATTR VkResult VKAPI_CALL GetDataGraphPipelinePropertiesARM(VkDevice
                                                                         const VkDataGraphPipelineInfoARM* pPipelineInfo,
                                                                         uint32_t propertiesCount,
                                                                         VkDataGraphPipelinePropertyQueryResultARM* pProperties);
-static VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceQueueFamilyDataGraphPropertiesARM(
-    VkPhysicalDevice physicalDevice, uint32_t queueFamilyIndex, uint32_t* pQueueFamilyDataGraphPropertyCount,
-    VkQueueFamilyDataGraphPropertiesARM* pQueueFamilyDataGraphProperties);
 static VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceQueueFamilyDataGraphProcessingEnginePropertiesARM(
     VkPhysicalDevice physicalDevice,
     const VkPhysicalDeviceQueueFamilyDataGraphProcessingEngineInfoARM* pQueueFamilyDataGraphProcessingEngineInfo,
@@ -3094,7 +3091,6 @@ static const std::unordered_map<std::string, void*> name_to_func_ptr_map = {
     {"vkCmdDispatchDataGraphARM", (void*)CmdDispatchDataGraphARM},
     {"vkGetDataGraphPipelineAvailablePropertiesARM", (void*)GetDataGraphPipelineAvailablePropertiesARM},
     {"vkGetDataGraphPipelinePropertiesARM", (void*)GetDataGraphPipelinePropertiesARM},
-    {"vkGetPhysicalDeviceQueueFamilyDataGraphPropertiesARM", (void*)GetPhysicalDeviceQueueFamilyDataGraphPropertiesARM},
     {"vkGetPhysicalDeviceQueueFamilyDataGraphProcessingEnginePropertiesARM",
      (void*)GetPhysicalDeviceQueueFamilyDataGraphProcessingEnginePropertiesARM},
     {"vkCmdSetAttachmentFeedbackLoopEnableEXT", (void*)CmdSetAttachmentFeedbackLoopEnableEXT},
diff --git a/tests/icd/test_icd.cpp b/tests/icd/test_icd.cpp
index 924d5c888..7d647e76f 100644
--- a/tests/icd/test_icd.cpp
+++ b/tests/icd/test_icd.cpp
@@ -1454,20 +1454,6 @@ static VKAPI_ATTR void VKAPI_CALL GetPhysicalDeviceExternalTensorPropertiesARM(
     }
 }
 
-static VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceQueueFamilyDataGraphPropertiesARM(VkPhysicalDevice physicalDevice, uint32_t queueFamilyIndex, uint32_t *pQueueFamilyDataGraphPropertyCount, VkQueueFamilyDataGraphPropertiesARM* pQueueFamilyDataGraphProperties) {
-
-    // TODO: Need a way for test to decide to support or not support various engines
-
-    if (pQueueFamilyDataGraphProperties == nullptr) {
-        *pQueueFamilyDataGraphPropertyCount = 1;
-    } else {
-        pQueueFamilyDataGraphProperties[0].sType = VK_STRUCTURE_TYPE_QUEUE_FAMILY_DATA_GRAPH_PROPERTIES_ARM;
-        pQueueFamilyDataGraphProperties[0].engine = { VK_PHYSICAL_DEVICE_DATA_GRAPH_PROCESSING_ENGINE_TYPE_DEFAULT_ARM, false };
-        pQueueFamilyDataGraphProperties[0].operation = { VK_PHYSICAL_DEVICE_DATA_GRAPH_OPERATION_TYPE_SPIRV_EXTENDED_INSTRUCTION_SET_ARM, "TOSA.001000.1", 0 };
-    }
-    return VK_SUCCESS;
-}
-
 static VKAPI_ATTR VkResult VKAPI_CALL
 GetPhysicalDeviceImageFormatProperties2(VkPhysicalDevice physicalDevice, const VkPhysicalDeviceImageFormatInfo2* pImageFormatInfo,
                                         VkImageFormatProperties2* pImageFormatProperties) {

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[spencer-lunarg]

@stefano-bucciarelli-arm this PR got messy

I merged in #11753

I would suggest closing this, and trying again with my idea of still having

    const std::unordered_map<uint32_t, std::vector<VkQueueFamilyDataGraphPropertiesARM>> queue_family_data_graph_properties;

but in CoreChecks::FinishDeviceSetup() detect if VK_ARM_tensor is enabled and then call

if (IsExtEnabled(extensions.vk_arm_tensors)) {
    physical_device_state->GetQueueFamilyDataGraphProps();
}

when queue_family_data_graph_properties is set inside GetQueueFamilyDataGraphProps

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author stefano-bucciarelli-arm not on autobuild list. Waiting for curator authorization before starting CI build.