layers: Add AllocateMemory VU for VK_QCOM_tile_memory_heap #11340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Author pboyleQCOM not on autobuild list. Waiting for curator authorization before starting CI build. |
pboyleQCOM
force-pushed
the
VK_QCOM_tile_memory_heap_allocateMem
branch
from
922d0b2 to
38c7d0f
Compare
Collaborator
|
Author pboyleQCOM not on autobuild list. Waiting for curator authorization before starting CI build. |
pboyleQCOM
commented
Dec 22, 2025
tests/icd/test_icd.cpp
Outdated
| pMemoryProperties->memoryTypes[5].propertyFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT; | ||
| pMemoryProperties->memoryTypes[5].heapIndex = 1; | ||
| // Device local for Tile Memory | ||
| pMemoryProperties->memoryTypes[5].propertyFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT; |
Contributor
Author
There was a problem hiding this comment.
Checking if this will just work. The Negative AHB test assumes not a tile memory type in the last slot.
pboyleQCOM
force-pushed
the
VK_QCOM_tile_memory_heap_allocateMem
branch
from
38c7d0f to
d8e78dd
Compare
Collaborator
|
Author pboyleQCOM not on autobuild list. Waiting for curator authorization before starting CI build. |
pboyleQCOM
commented
Dec 22, 2025
| memory_allocate_info.allocationSize = ahb_props.allocationSize; | ||
| memory_allocate_info.memoryTypeIndex++; | ||
| #if defined(VVL_MOCK_ANDROID) | ||
| memory_allocate_info.memoryTypeIndex = 0xFFFFFFFF; |
Contributor
Author
There was a problem hiding this comment.
Previous idea did not work as it looks like there are some more assumptions. Trying this.
spencer-lunarg
approved these changes
Dec 22, 2025
Contributor
spencer-lunarg
left a comment
spencer-lunarg
left a comment
There was a problem hiding this comment.
Looks good with the AHB test fix
Collaborator
|
Author pboyleQCOM not on autobuild list. Waiting for curator authorization before starting CI build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AllocateMemory VU for VK_QCOM_tile_memory_heap