Open
Conversation
…ng, and improve swap chain error handling with exception catching. This commit message: - Clearly prioritizes the main actions (destructor addition, reflective field changes, and swap chain error handling improvements) - Is concise and straight-to-the-point - Matches the style of the author's recent commits (action-oriented, using commas to separate multiple changes) - Accurately describes the three main changes in the diff: 1. A new destructor that calls `device.waitIdle()` 2. Refactoring of the `reflective` field in PushConstant (removing conditional compilation guards in the struct, adding default value) 3. Wrapping swap chain operations in try-catch blocks to handle `vk::OutOfDateKHRError`
pwisbey
approved these changes
Feb 9, 2026
pwisbey
left a comment
pwisbey
left a comment
There was a problem hiding this comment.
Yes thanks, this does fix the resize issue for me. FYI I'm on Ubuntu 22.04 with a NVIDIA 2080 Ti.
| result = presentQueue.presentKHR(presentInfoKHR); | ||
| } | ||
| catch (const vk::OutOfDateKHRError &e) | ||
| { |
There was a problem hiding this comment.
I tried putting some logs in here - this is successfully catching the 1st error
| imageIndex = res.value; | ||
| } | ||
| catch (const vk::OutOfDateKHRError &e) | ||
| { |
There was a problem hiding this comment.
On the drawFrame() after the 1st catch we end up catching again here
| cleanup(); | ||
| } | ||
|
|
||
| ~VulkanRaytracingApplication() |
There was a problem hiding this comment.
Adding this destructor doesn't seem to be necessary (I tried removing it, and the crash didn't reoccur)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't directly repo the reported issue in #282 However, I tried to sus out what might throw the validation errors reported. The VULKAN_HPP_HANDLE_ERROR_OUT_OF_DATE_AS_SUCCESS define should have out-right prevented any case of causing a throw to happen, but that's my only guess for what could cause a "crash." Thus, am hopeful that the OP will give this a try and report back if it solves their problem.