Clarify VkPhysicalDeviceClusterCullingShaderVrsFeaturesHUAWEI structextends relation #2608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Vulkan XML registry to clarify the
structextendsrelationship ofVkPhysicalDeviceClusterCullingShaderVrsFeaturesHUAWEI.Currently, this structure extends only
VkPhysicalDeviceClusterCullingShaderFeaturesHUAWEI. This is the only known case in the registry where a feature struct extends another feature struct, rather thanVkPhysicalDeviceFeatures2andVkDeviceCreateInfodirectly.This raises several questions for clarification:
Intentional dependency?
Is
VkPhysicalDeviceClusterCullingShaderVrsFeaturesHUAWEIintended to be activatable only whenVkPhysicalDeviceClusterCullingShaderFeaturesHUAWEIis also enabled?Possible correction to
structextends:Should the
structextendsattribute be changed toVkPhysicalDeviceFeatures2,VkDeviceCreateInfo(and remove
VkPhysicalDeviceClusterCullingShaderFeaturesHUAWEIfromstructextends),following the pattern used by other feature definitions?
Specification clarity:
The current Vulkan specification section on feature enablement (excerpt below) does not explicitly mention dependent feature relationships:
Would it be helpful to add an explicit note or clarification to the specification describing whether a feature struct can depend on another feature struct being enabled, or whether such nested feature relationships are allowed at all?