Skip to content

Make local path filesystem helper functions private#579

Merged
popescu-v merged 2 commits into
mainfrom
570-using-gcs-files---valueerror-invalid-local-path-or-uri
May 19, 2026
Merged

Make local path filesystem helper functions private#579
popescu-v merged 2 commits into
mainfrom
570-using-gcs-files---valueerror-invalid-local-path-or-uri

Conversation

@popescu-v
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v commented May 18, 2026

Also update the Core api code accordingly: use the public, portable for remote paths, filesystem functions.

closes #570


TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

Update the Core api code accordingly: use the public, portable for
remote paths, filesystem functions.

closes #570
@popescu-v popescu-v self-assigned this May 18, 2026
@popescu-v popescu-v linked an issue May 18, 2026 that may be closed by this pull request
@popescu-v popescu-v requested a review from tramora May 18, 2026 12:30
Copy link
Copy Markdown
Collaborator

@tramora tramora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@popescu-v popescu-v requested a review from tramora May 18, 2026 15:44
@popescu-v popescu-v force-pushed the 570-using-gcs-files---valueerror-invalid-local-path-or-uri branch from 1a5f430 to c33a454 Compare May 19, 2026 08:39
@popescu-v popescu-v merged commit 5257dbe into main May 19, 2026
18 checks passed
@popescu-v popescu-v deleted the 570-using-gcs-files---valueerror-invalid-local-path-or-uri branch May 19, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using GCS files - ValueError : Invalid local path or URI

2 participants