Conversation
popescu-v
approved these changes
Jan 14, 2026
Collaborator
popescu-v
left a comment
There was a problem hiding this comment.
LGTM, but:
- we need to take a look at the api-docs workflow execution log and check that there are no build warnings, then download the build artifact locally and visually inspect the rendered result via
python -m http.serverfor instance; - we need to check the results of the (manually launched) workflows conda and pip - check that the build and test jobs succeed;
- [debatable] we need to manually launch the expensive tests in the tests workflow.
The latter points have been done and:
- pip and conda succeed
- tests is executing: https://github.com/KhiopsML/khiops-python/actions/runs/20996393286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #527
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html