Merge 2.5.0 to main #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.5.0: CA Bundle with ConfigMap + GKE Ambient Credentials Documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges the 2.5.0 release branch to main, introducing new features for CA bundle configuration flexibility and ambient credential improvements.
Changes:
- Added support for ConfigMap-based CA trust bundles alongside existing Secret-based configuration
- Introduced
caBundleKeyspecification to select specific keys from CA bundle resources - Added Azure credential timeout and Google Kubernetes Engine (GKE) workload identity documentation
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/issuer_controller_test.go | Added comprehensive test coverage for new CA bundle configuration options |
| internal/controller/issuer_controller.go | Implemented ConfigMap support and key selection for CA bundles |
| internal/command/client.go | Added timeout for Azure ambient credential token retrieval |
| e2e/run_tests.sh | Extended E2E tests to validate CA bundle Secret/ConfigMap functionality |
| e2e/README.md | Updated requirements and documented CA certificate configuration |
| e2e/.gitignore | Added certs directory to gitignore for CA certificate storage |
| e2e/.env.example | Added DISABLE_CA_CHECK environment variable |
| docsource/content.md | Updated documentation for new CA bundle specifications |
| docs/ca-bundle/README.md | New comprehensive CA bundle documentation including trust-manager integration |
| docs/ambient-providers/google.md | New documentation for GKE workload identity configuration |
| deploy/charts/command-cert-manager-issuer/values.yaml | Added ConfigMap access configuration and environment variable support |
| deploy/charts/command-cert-manager-issuer/templates/* | Updated RBAC and deployment templates for ConfigMap access |
| deploy/charts/command-cert-manager-issuer/templates/crds/* | Updated CRD schemas with new CA bundle fields |
| config/crd/bases/* | Updated base CRD definitions with new specifications |
| cmd/main.go | Added ConfigMap access flag and cache configuration |
| api/v1alpha1/issuer_types.go | Added CaBundleConfigMapName and CaBundleKey fields to IssuerSpec |
| README.md | Updated root documentation with new CA bundle references |
| Makefile | Updated E2E test command |
| CHANGELOG.md | Added v2.5.0 release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "🔎 Checking certificate request status..." | ||
|
|
||
| if [[ ! $(kubectl wait --for=condition=Ready certificaterequest/$CR_CR_NAME -n $ISSUER_NAMESPACE --timeout=30s) ]]; then | ||
| if [[ ! $(kubectl wait --for=condition=Ready certificaterequest/$CR_CR_NAME -n $ISSUER_NAMESPACE --timeout=70s) ]]; then |
There was a problem hiding this comment.
The timeout value increased from 30s to 70s without explanation. Consider documenting why this specific timeout value was chosen (possibly related to the 10s Azure timeout added in client.go plus additional buffer), or extract it as a configurable constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release-2.5 to main - Automated PR