Remove error_message_searchspace_fully_observed message in BO#338
Merged
Remove error_message_searchspace_fully_observed message in BO#338
error_message_searchspace_fully_observed message in BO#338Conversation
fjwillemsen
approved these changes
Oct 14, 2025
Collaborator
fjwillemsen
left a comment
There was a problem hiding this comment.
Yes, this looks good to me.
Collaborator
|
Good change, this should be handled by the interface, not individual search strategies, so this is definitely more appropriate. Although if the search space is so small as to be fully observed BO should probably not have been used in the first place. |
|
Member
Author
I fully agree! However, when setting time limit, you can't know in advance if that's sufficient to explore the full search space. I will merge this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Currently, BO throws an exception once it has fully explored the search space. This means it cannot be used for small(er) search spaces, as there is no way to catch this exception and still get the results from Kernel Tuner.
This PR replaces these exception by just breaking from the loop.
@fjwillemsen is this change ok? Could it have any adverse effects?