Recalculate metrics for each configuration in simulation runner#307
Merged
benvanwerkhoven merged 1 commit intomasterfrom Nov 12, 2025
Merged
Recalculate metrics for each configuration in simulation runner#307benvanwerkhoven merged 1 commit intomasterfrom
benvanwerkhoven merged 1 commit intomasterfrom
Conversation
|
Collaborator
|
This is still in draft but I think it can be merged? |
Member
Author
|
This can be merged! |
benvanwerkhoven
approved these changes
Nov 12, 2025
Collaborator
benvanwerkhoven
left a comment
benvanwerkhoven
left a comment
There was a problem hiding this comment.
Looks great and has been tested!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the simulation runner ignores the metrics provided in
tune_kernel.This PR makes the simulation runner recalculate the provided metrics for each configuration. This is useful when using the simulation runner on a cache file with different metrics than provided by the cache file.