Rework canAddNotes and canAddNotesWithErrorDetails to more closely match AnkiConnect desktop #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mainly made to address the issue mentioned #87, but there are also a few additional changes. This probably broke when Yomitan added support for more than two card formats yomidevs/yomitan#1930.
By default Yomitan sets up three Anki card formats. If one of the formats is not configured, it will still get queried into Ankiconnect with an empty deck name, model name and fields array. This works fine on Ankiconnect desktop, as it will only validate the input and throw an Exception after canAddNote calls createNote, but did not work in Ankiconnect Android, because it parses the note first, and accesses the fields array without checking whether this has any entries.
field and value now default to null and are only updated when the fields array is not empty.
The previous implementation of canAddNotes from #60 assumed that note options and model are the same for all notes Yomitan which is not the case anymore. This PR addresses this, and also implements the remaining error messages for canAddNotesWithError.