Return RuntimeError when --deduplicate-hardlinks is used with multiple arguments#348
Draft
Return RuntimeError when --deduplicate-hardlinks is used with multiple arguments#348
Conversation
Co-authored-by: KSXGitHub <11488886+KSXGitHub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix pdu to return RuntimeError for multiple arguments
Return RuntimeError when --deduplicate-hardlinks is used with multiple arguments
Mar 11, 2026
Performance Regression Reportscommit: 6d86325 There are no regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
--deduplicate-hardlinkswith multiple path arguments is inherently unreliable across device boundaries and overlapping trees. Rather than attempting to silently fix up the argument list,pdunow rejects this combination outright.Changes
RuntimeErrorvariant:DeduplicateHardlinkMultipleArgs(exit code 7,#[cfg(unix)]) — emitted when--deduplicate-hardlinksis passed alongside more than one path argumentoverlapping_argumentsmodule: the path-deduplication logic (remove_overlapping_paths,find_overlapping_paths_to_remove, etc.) is no longer needed and has been deleted entirelyApp::run()no longer takesmut self: previously required to mutateargs.filesin-placehardlinks_deduplication_multi_args.rsnow asserts the error path instead of the old overlapping-removal behaviorCloses #347
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.