refactor: use `Vec<OsString>` path-component keys in coloring map#341

Closed

Copilot wants to merge 22 commits intomasterfrom

copilot/address-pr-339-discussion-point

Commits on Mar 7, 2026

feat: lscolors integration, multi-color support, render_row macro, destructure TreeHorizontalSlice

Copilot
and
KSXGitHub
committed
refactor: single LazyLock<AnsiPrefixes> + format_args! with row destructuring

Copilot
and
KSXGitHub
committed
refactor: rename aligned_colored/aligned_normal to aligned_colored_slice/aligned_plain_slice

Copilot
and
KSXGitHub
committed
refactor: consolidate AnsiPrefixes at crate root; Coloring struct; ColoredTreeHorizontalSlice

Copilot
and
KSXGitHub
committed
refactor(r7): rename AnsiPrefixes→LsColors, private fields, restructure coloring, move color logic to App::run

Copilot
and
KSXGitHub
committed
refactor(r8): rename field, minimize visibility, move color calc, diverse-kinds workspace, fix tests

Copilot
and
KSXGitHub
committed
test: add predefined LS_COLORS constant to color tests

Copilot
and
KSXGitHub
committed
Replace unsafe set_var in color_always test with LsColors FromStr

Copilot
and
KSXGitHub
committed
Address review comments: refactor LsColors, add color test without LS_COLORS

Copilot
and
KSXGitHub
committed
fix: rename LsColors::from_str to from_ls_colors_string to fix clippy lint

Copilot
and
KSXGitHub
committed
fix: use full PathBuf key in build_coloring_map to prevent basename collision

Copilot
and
KSXGitHub
committed
chore: remove dead src/ansi_prefixes.rs file

Copilot
and
KSXGitHub
committed
refactor: address review threads 71-75: remove Hash+Eq bounds, rename ansi_prefixes to ls_colors, update doc comment, make lscolors optional under color feature

Copilot
and
KSXGitHub
committed
revert: remove color feature flag, make lscolors an unconditional dependency

Copilot
and
KSXGitHub
committed
Initial plan
Copilot
committed
Merge branch 'pr339' into copilot/address-pr-339-discussion-point
Copilot
committed
refactor: use Vec<OsString> as coloring map keys instead of PathBuf

Copilot
and
KSXGitHub
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: use `Vec<OsString>` path-component keys in coloring map#341

refactor: use `Vec<OsString>` path-component keys in coloring map#341
Copilot wants to merge 22 commits intomasterfrom
copilot/address-pr-339-discussion-point

Commits on Mar 6, 2026

Initial plan

Add --color flag and Visualizer coloring support

Address review feedback: Color enum, minimize const visibility, simplify rendering

Address second review round: rename Colorless→Normal, refactor is_dir, update docs

Address third review round: ColoredSlice, rename coloring_map/is_dir, remove redundant attributes

Commits on Mar 7, 2026

feat: lscolors integration, multi-color support, render_row macro, destructure TreeHorizontalSlice

refactor: single LazyLock<AnsiPrefixes> + format_args! with row destructuring

refactor: rename aligned_colored/aligned_normal to aligned_colored_slice/aligned_plain_slice

refactor: consolidate AnsiPrefixes at crate root; Coloring struct; ColoredTreeHorizontalSlice

refactor(r7): rename AnsiPrefixes→LsColors, private fields, restructure coloring, move color logic to App::run

refactor(r8): rename field, minimize visibility, move color calc, diverse-kinds workspace, fix tests

test: add predefined LS_COLORS constant to color tests

Replace unsafe set_var in color_always test with LsColors FromStr

Address review comments: refactor LsColors, add color test without LS_COLORS

fix: rename LsColors::from_str to from_ls_colors_string to fix clippy lint

fix: use full PathBuf key in build_coloring_map to prevent basename collision

chore: remove dead src/ansi_prefixes.rs file

refactor: address review threads 71-75: remove Hash+Eq bounds, rename ansi_prefixes to ls_colors, update doc comment, make lscolors optional under color feature

revert: remove color feature flag, make lscolors an unconditional dependency

Initial plan

Merge branch 'pr339' into copilot/address-pr-339-discussion-point

refactor: use Vec<OsString> as coloring map keys instead of PathBuf