Remove redundant 'jquery' global in .eslintrc.js and add 'browser' global for extension consistency#204
Open
MatrixNeoKozak wants to merge 1 commit into
Conversation
…obal for extension consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .eslintrc.js file declares '$' and 'Mustache' as globals, and 'jquery' is already set to true in the env. This is redundant and may cause confusion. Also, the 'browser' global is already declared in env, but the extension uses 'chrome' or 'browser' depending on context. Adding 'chrome' as a global helps linting for Chrome extension code. This is a minor cleanup to align with modern linting best practices.