Add new top-opt implementation#13
Open
utkarshyashvardhan11 wants to merge 8 commits intoJuliaTopOpt:mainfrom
Open
Add new top-opt implementation#13utkarshyashvardhan11 wants to merge 8 commits intoJuliaTopOpt:mainfrom
utkarshyashvardhan11 wants to merge 8 commits intoJuliaTopOpt:mainfrom
Conversation
src/Top_opt_3d/top3d_caller.m
Outdated
| % === downloaded from the website: http://www.top3dapp.com/ === | ||
| % === ----------------------------------------------------------------- === | ||
| % === Disclaimer: === | ||
| % === The authors reserves all rights for the program. === |
Member
There was a problem hiding this comment.
Please remove the Matlab script from the repo. Also please mention in the Julia translation that the author gave us permission to translate the code to Julia under an MIT license. I also suggest committing the email exchange as a pdf to the repo.
Collaborator
Author
There was a problem hiding this comment.
I have made the changes as suggested.
| vert = [x y z; x y-hx z; x+hx y-hx z; x+hx y z; x y z+hx; x y-hx z+hx; x+hx y-hx z+hx; x+hx y z+hx]; | ||
| vert[:, 2:3] = vert[:, 3:-1:2]; vert[:, 2, :] = -vert[:, 2, :]; | ||
| if flag == false | ||
| scene = mesh(vert, faces, color = RGB(0.2+0.8*(1-rho[j,i,k]), 0.2+0.8*(1-rho[j,i,k]), 0.2+0.8*(1-rho[j,i,k])), shading = NoShading; axis=(; show_axis = false)) |
Member
There was a problem hiding this comment.
this doesn't work on my machine, there are 2 issues:
- you can't have kwargs before the
; - I think
shadingshould be booleantrue/false
| scene = mesh(vert, faces, color = RGB(0.2+0.8*(1-rho[j,i,k]), 0.2+0.8*(1-rho[j,i,k]), 0.2+0.8*(1-rho[j,i,k])), shading = NoShading; axis=(; show_axis = false)) | ||
| flag = true; | ||
| else | ||
| mesh!(vert, faces, color = RGB(0.2+0.8*(1-rho[j,i,k]), 0.2+0.8*(1-rho[j,i,k]), 0.2+0.8*(1-rho[j,i,k])), shading = NoShading) |
Member
There was a problem hiding this comment.
I think shading should be boolean, true/false
Member
|
Thanks for the PR. This seems to work once the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new topology optimization implementation in Julia using the educational paper - An efficient 3D topology optimization code written in Matlab (Authors- Kai Liu & Andrés Tovar). Link to paper- https://link.springer.com/article/10.1007/s00158-014-1107-x. Also, comparing the efficiency of the Julia implementation with corresponding MATLAB code.