Allow manually defining symbol visibility in static builds #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
approved these changes
Nov 15, 2025
Member
|
Seems reasonable, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few build pipelines where I statically link utf8proc into a binary or other shared libs, but still need the symbols to be exported (e.g., plugins).
Because the CMake build system unconditionally defines UTF8PROC_STATIC, and there is no ifndef guard around UTF8PROC_DLLEXPORT, manually defining it with a flag is insufficient.
This PR just adds a small ifndef guard around the code block to allow manually defining
-DUTF8PROC_DLLEXPORT.