1.10: Fixed tests for builds without GPL SuiteSparse#698
Open
stemann wants to merge 2 commits intoJuliaSparse:release-1.10from
Open
1.10: Fixed tests for builds without GPL SuiteSparse#698stemann wants to merge 2 commits intoJuliaSparse:release-1.10from
stemann wants to merge 2 commits intoJuliaSparse:release-1.10from
Conversation
GPL-dependent test imports are gated on Base.USE_GPL_LIBS so the test suite no longer references solver bindings that are unavailable in non-GPL builds. The non-GPL factorization tests fall back to ordinary sparse LU and QR paths, which need mutable SparseMatrixCSC inputs rather than fixed-structure matrices. FixedSparseCSC therefore gains the copy and conversion behavior needed for sparse(a) to produce a normal SparseMatrixCSC and keep those fallback test paths working.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #698 +/- ##
=============================================
Coverage 92.64% 92.64%
=============================================
Files 12 12
Lines 7678 7687 +9
=============================================
+ Hits 7113 7122 +9
Misses 565 565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stemann
force-pushed
the
feature/fix-non-gpl-tests
branch
from
8266a34 to
6591807
Compare
stemann
force-pushed
the
feature/fix-non-gpl-tests
branch
from
6591807 to
13b2f1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPL-dependent test imports are gated on Base.USE_GPL_LIBS so the test suite no longer references solver bindings that are unavailable in non-GPL builds.
The non-GPL factorization tests fall back to ordinary sparse LU and QR paths, which need mutable SparseMatrixCSC inputs rather than fixed-structure matrices. FixedSparseCSC therefore gains the copy and conversion behavior needed for sparse(a) to produce a normal SparseMatrixCSC and keep those fallback test paths working.