Remove some unnecessary methods that cause invalidations#694
Open
JamesWrigley wants to merge 1 commit intoJuliaSparse:mainfrom
Open
Remove some unnecessary methods that cause invalidations#694JamesWrigley wants to merge 1 commit intoJuliaSparse:mainfrom
JamesWrigley wants to merge 1 commit intoJuliaSparse:mainfrom
Conversation
- A `axes(::AbstractQ)` already exists in LinearAlgebra that does the same thing. - Julia already has a generic `Base.size(x, dim)` method that uses `Base.size(x)`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 84.35% 84.31% -0.05%
==========================================
Files 13 13
Lines 9347 9345 -2
==========================================
- Hits 7885 7879 -6
- Misses 1462 1466 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Maybe you want to remove these lines as well: SparseArrays.jl/src/solvers/spqr.jl Line 118 in 3ab784c SparseArrays.jl/src/solvers/cholmod.jl Line 1290 in 3ab784c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
axes(::AbstractQ)already exists in LinearAlgebra that does the same thing.Base.size(x, dim)method that usesBase.size(x).Should fix these invalidations seen when loading CUDA.jl on 1.13:
Could we backport this to 1.13?