Add rotate option to profile_solvers layout#201
Open
arnavk23 wants to merge 6 commits intoJuliaSmoothOptimizers:mainfrom
Open
Add rotate option to profile_solvers layout#201arnavk23 wants to merge 6 commits intoJuliaSmoothOptimizers:mainfrom
profile_solvers layout#201arnavk23 wants to merge 6 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
…bjects directly. It now asserts size(p.layout.grid) == (4, 2) for the default layout and (2, 4) for rotate = true, which is stable and avoids the false failure I saw in CI.
profile_solvers layout
There was a problem hiding this comment.
Pull request overview
Adds a rotate keyword to profile_solvers to allow swapping the layout orientation of the generated profile grid.
Changes:
- Introduce
rotate::Bool = falsetoprofile_solversand adjustlayout/sizecomputation accordingly. - Document the new
rotatekeyword in theprofile_solversdocstring. - Update
test/profiles.jlto exerciserotate = true.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/profiles.jl |
Adds rotate keyword and uses it to compute plot grid dimensions and figure size. |
test/profiles.jl |
Calls profile_solvers with rotate = true as part of smoke testing plot generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…navk23/SolverBenchmark.jl into fix-issue-115-rotate-profiles
Contributor
Author
|
tmigot
approved these changes
Apr 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 76.71% 86.28% +9.57%
==========================================
Files 12 10 -2
Lines 292 299 +7
==========================================
+ Hits 224 258 +34
+ Misses 68 41 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@arnavk23 Could you please show an example of a plot with |
Contributor
Author
|
@dpo Seeing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


@dpo @tmigot
Fixes #115