Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s breakage CI to delegate execution to a reusable GitHub Actions workflow, aligning this repo with the shared JuliaSmoothOptimizers organization infrastructure.
Changes:
- Replaced the in-repo Breakage workflow implementation with a call to a reusable workflow.
- Removed the local
.breakagehelper project/scripts now intended to live in shared org infrastructure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/Breakage.yml | Replaces the local breakage matrix/build/test jobs with a reusable workflow call. |
| .breakage/Project.toml | Removes local breakage workflow dependencies (now expected to be provided by shared infra). |
| .breakage/get_jso_users.jl | Removes local script for computing dependent JSO packages (now expected to be provided by shared infra). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| breakage: | ||
| uses: MaxenceGollier/.github_JSO/.github/workflows/Breakage.yml@comment |
There was a problem hiding this comment.
The reusable workflow is referenced via a mutable branch ref (@comment) in an external repository. For supply-chain safety and reproducibility, pin the uses: reference to an immutable commit SHA (or a protected tag) and then switch to the org-owned .github repo once available.
| on: | ||
| pull_request: | ||
|
|
||
| pull_request: | ||
| types: [opened, synchronize, reopened] |
There was a problem hiding this comment.
Indentation under on: is inconsistent with the rest of the repo’s workflows (they use two-space indentation). Consider reformatting this block to the standard layout to avoid YAML readability issues and keep workflow files consistent.
|
What is implemented
I try to use the reusable workflow implemented here for the
Breakage.ymlworkflow.How do I implement it
I removed the
.breakagefolder because the code there is now shared accross the organization.I added the workflow located in my fork, we need to change this once JuliaSmoothOptimizers/.github#18 has been merged.
Why do I implement it
Unify the JSO infrastructure.