Removing public m from PureJuMP wrappers#422
Open
arnavk23 wants to merge 1 commit into
Open
Conversation
… by removing public `m` from PureJuMP wrappers
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR simplifies the arglin* problem constructors by removing the configurable m keyword argument and always using m = 2n observations.
Changes:
- Removed the
mkeyword argument (and its validation/warning) fromarglina,arglinb, andarglinc. - Hard-coded the number of observations to
m = 2 * nin each constructor.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/PureJuMP/arglinc.jl | Removes configurable m; forces m = 2*n unconditionally. |
| src/PureJuMP/arglinb.jl | Removes configurable m; forces m = 2*n unconditionally. |
| src/PureJuMP/arglina.jl | Removes configurable m; forces m = 2*n unconditionally. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+16
| function arglinc(args...; n::Int = default_nvar, kwargs...) | ||
| m = 2 * n |
Comment on lines
+15
to
+16
| function arglinb(args...; n::Int = default_nvar, kwargs...) | ||
| m = 2 * n |
Comment on lines
+15
to
+16
| function arglina(args...; n::Int = default_nvar, kwargs...) | ||
| m = 2 * n |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tmigot Fixes #421