redo HomotopyDensityDFG, creep change serialization approach#1231
Draft
redo HomotopyDensityDFG, creep change serialization approach#1231
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1231 +/- ##
===========================================
- Coverage 80.85% 80.28% -0.58%
===========================================
Files 49 50 +1
Lines 2648 2693 +45
===========================================
+ Hits 2141 2162 +21
- Misses 507 531 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Johannes Terblanche <Affie@users.noreply.github.com>
Member
Author
|
Hi @Affie , i was having some trouble with json ignore -- i'll try a bit more and will post here if i learn anything more in the next 30 mins or so. Think this is at good enough a point for you to take over on this PR please |
formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
Author
|
shoot, i messed up -- still a few clean ups that i missed (i blame lack of sleep) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative redo of -- creep change implementation of serialization:
At the time of writing, 1230 is good enough for AMP v0.15.0-alpha tests to pass. This redo is easiest path to make sure DFG serialization also works for new HomotopyDensityDFG (replaces StoredHomotopyBelief). Some detail on abstracts in new HomotopyRepr