Conversation
Co-authored-by: Christopher Doris <github.com/cjdoris>
* change julia wrapper hierarchy * remove RawValue, TypeValue and ModuleValue from juliacall * add JlBase.__init__ and store nothing/true/false specially * more general numeric operators * rounding methods, jl_to_py, remove jlwrap numbers * update release notes * remove references to nonexistent types * add jl_callback * simpler iteration * simplify callbacks (pyfunc etc) * change to pyjl(x) * rename ArrayValue to JlArray etc * __init__ for all * mixins for consistency * improve pymacro docstring * jlwrap tests * remove old tests * pyjlset tests * pyjldict tests * pyjlio tests * pyjlarray tests * pyjlvector tests * pyjl hash, == and iter * add JlContainer * eliminate mixins and add contains and clear to JlCollection * fix keys, values, items * fix tests * tests for JlCollection * update jlwrap docs * Jl tests * JlDict tests * PySet tests * JlIO tests * more JlIO tests * rename julia wrapper classes * enable CI on v1 branch * Jl.jl_eval fix return type * adapt python tests to latest version * propagate seval -> jl_eval --------- Co-authored-by: Christopher Doris <github.com/cjdoris>
* comparisons now return Bool not Py * fix bug in JlIO.fileno() from change of return type of fd() --------- Co-authored-by: Christopher Doris <github.com/cjdoris>
* Delete unnecessary comparison operators These are already defined by Base in terms of other comparison operators, so they cause a ton of invalidations. * use :static scheduler for GIL tests possible fix for CI crashes seen in these tests --------- Co-authored-by: Christopher Doris <github.com/cjdoris>
* reparameterise PyArray * undocumented unused flags * update release notes * fix elsize bug * update tests for new PyArray parameterisation --------- Co-authored-by: Christopher Doris <github.com/cjdoris>
* add a migration guide for v1 * actually add the migration guide to the docs * add PyArray to migration guide * tweaks --------- Co-authored-by: Christopher Doris <github.com/cjdoris>
Co-authored-by: Dani Pinyol <dani@avatarcognition.com>
Contributor
|
I'm kinda interested in getting this over the finish line to get those sweet sweet invalidation fixes 😛 Is there anything I could help out with? For example, would it help if I started going through the issues in https://github.com/JuliaPy/PythonCall.jl/milestone/1 and making PRs for them? |
Contributor
|
(gentle bump, still happy to help out if you like) |
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
Author
Thanks for the offer! I'd be happy to take PRs but that milestone is a bit of a jumble. Some of the issues contradict each other, particularly around Let me tidy it up and get back to you. Or if you let me know what you'd like to work on I can advise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes that will eventually become v1. Only breaking changes on this branch, everything else should go on main.
Don't merge directly to here, make PRs.
See releasenotes.md for changes.