Skip to content

Assignment to exc in soft scope is ambiguous #905

Open
heetbeet wants to merge 1 commit intoJuliaPy:masterfrom
heetbeet:patch-1
Open

Assignment to exc in soft scope is ambiguous #905
heetbeet wants to merge 1 commit intoJuliaPy:masterfrom
heetbeet:patch-1

Conversation

@heetbeet
Copy link
Copy Markdown

@heetbeet heetbeet commented Jun 2, 2021

Suppress warning:

┌ Warning: Assignment to `#6#exc` in soft scope is ambiguous because a global variable by the same name exists: `#6#exc` will be treated as a new local. Disambiguate by using `local #6#exc` to suppress this warning or `global #6#exc` to assign to the existing global variable.
└ @ C:\Users\simon\devel\empty_app\bin\julia\localdepot\packages\PyCall\BD546\src\PyCall.jl:654

Suppress warning:

```
┌ Warning: Assignment to `#6#exc` in soft scope is ambiguous because a global variable by the same name exists: `#6#exc` will be treated as a new local. Disambiguate by using `local #6#exc` to suppress this warning or `global #6#exc` to assign to the existing global variable.
└ @ C:\Users\simon\devel\empty_app\bin\julia\localdepot\packages\PyCall\BD546\src\PyCall.jl:654
```
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.06%. Comparing base (8a98fb4) to head (9c7e90a).
⚠️ Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   68.03%   68.06%   +0.03%     
==========================================
  Files          20       20              
  Lines        1980     1982       +2     
==========================================
+ Hits         1347     1349       +2     
  Misses        633      633              
Flag Coverage Δ
unittests 68.06% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj
Copy link
Copy Markdown
Member

stevengj commented Jun 3, 2021

This isn't the correct fix because it only works for @pywith statements in global scope.

@stevengj
Copy link
Copy Markdown
Member

stevengj commented Jun 3, 2021

The right fix is probably to wrap the whole try .. finally in a let exc=true block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants