Fix some JET warnings regarding matching methods for strip(...) and parse(...)#87
Open
DilumAluthge wants to merge 1 commit intomasterfrom
Open
Fix some JET warnings regarding matching methods for strip(...) and parse(...)#87DilumAluthge wants to merge 1 commit intomasterfrom
strip(...) and parse(...)#87DilumAluthge wants to merge 1 commit intomasterfrom
Conversation
DilumAluthge
changed the title
strip(...) and parse(...)strip(...) and parse(...)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 93.61% 93.75% +0.13%
==========================================
Files 2 2
Lines 94 96 +2
==========================================
+ Hits 88 90 +2
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…`parse(...)` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:210 │ no matching method found `parse(::Type{Int64}, ::Nothing)` (1/2 union split): SlurmClusterManager.parse(SlurmClusterManager.Int, (m::RegexMatch{String})[1]::Union{Nothing, SubString{String}}) └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:210 │ no matching method found `parse(::Type{Int64}, ::Nothing)` (1/2 union split): SlurmClusterManager.parse(SlurmClusterManager.Int, (m::RegexMatch{String})[1]::Union{Nothing, SubString{String}})::Int64 └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:211 │ no matching method found `strip(::Nothing)` (1/2 union split): SlurmClusterManager.strip((m::RegexMatch{String})[2]::Union{Nothing, SubString{String}}) └──────────────────── ``` ``` ┌ (::SlurmClusterManager.var"#25#26")() @ SlurmClusterManager /mystuff/SlurmClusterManager.jl/src/slurmmanager.jl:211 │ no matching method found `strip(::Nothing)` (1/2 union split): SlurmClusterManager.strip((m::RegexMatch{String})[2]::Union{Nothing, SubString{String}})::SubString{String} └──────────────────── ``` (cherry picked from commit 79b9476)
DilumAluthge
force-pushed
the
dpa/fix-jet-errors-strip-parse
branch
from
8199397 to
daa709e
Compare
Member
Author
|
@kleinhenz Could you review this? |
Member
Author
|
Bump @kleinhenz - any objection to me merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked out of #86