Skip to content

Hotfix some direct solve ambiguities#181

Open
termi-official wants to merge 7 commits intoJuliaLinearAlgebra:masterfrom
termi-official:master
Open

Hotfix some direct solve ambiguities#181
termi-official wants to merge 7 commits intoJuliaLinearAlgebra:masterfrom
termi-official:master

Conversation

@termi-official
Copy link
Copy Markdown

Hotfix as proposed in JuliaArrays/BlockArrays.jl#319

@termi-official termi-official marked this pull request as draft November 10, 2023 15:23
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2023

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (d44e944) to head (300ceaf).
⚠️ Report is 77 commits behind head on master.

Files with missing lines Patch % Lines
ext/ArrayLayoutsSparseArraysExt.jl 0.00% 2 Missing ⚠️
src/ldiv.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d44e944) and HEAD (300ceaf). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (d44e944) HEAD (300ceaf)
13 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #181       +/-   ##
==========================================
- Coverage   87.47%   0.00%   -87.48%     
==========================================
  Files          11      11               
  Lines        1812    1712      -100     
==========================================
- Hits         1585       0     -1585     
- Misses        227    1712     +1485     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@termi-official termi-official changed the title Hotfix WR form ambiguity. Hotfix some direct solve ambiguities Nov 10, 2023
@termi-official termi-official marked this pull request as ready for review November 10, 2023 18:04
@termi-official
Copy link
Copy Markdown
Author

I am still lost why only the WY form has issues, but this PR should fix it. Plus it fixes ambiguities with some sparse direct solve dispatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant